Vote #79840: Drop setting "Blind carbon copy recipients (bcc)" - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #79840

完了

Drop setting "Blind carbon copy recipients (bcc)"

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Email notifications_9

対象バージョン:

5.0.0_155

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/30820

category_id:

version_id:

155

issue_org_id:

30820

author_id:

107353

assigned_to_id:

107353

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

From #26791:

h3. BCC recipients

Since each user gets their own mail, we can probably remove the setting to send mails with BCC completely. If plugins want to send mails to non-user recipients, we would have to make sure to either set the recipients manually on BCC or group them appropriately. It is not a required setting in Redmine core anymore though.

I agree, the setting doesn't make any sense now.

journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1
The setting has no effect since #26791 was implemented.
--------------------------------------------------------------------------------
Probably the patch also resolves #8516 because Redmine with the patch applied does not remove To field.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Go MAEDA wrote:
> Probably the patch also resolves #8516 because Redmine with the patch applied does not remove To field.

Agree. Also, #30787 can be closed now from my point of view if you don't refer to other problem.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Updated to remove @bcc_recipients@ from settings.yml as well.
--------------------------------------------------------------------------------
Since this patch adds a migration, I am changing the target version from 4.0.2 to 4.1.0.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Removing a setting may cause some plugins to error.
Setting it to a major release.
--------------------------------------------------------------------------------
I've rebased the branch for the current trunk
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I've rebased the patch for the current trunk

--------------------------------------------------------------------------------
If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.

That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)
--------------------------------------------------------------------------------
Holger Just wrote:
> If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.
>
> That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)

The next version is version:"5.0.0" which will contain other removals or breaking changes. I'm in favour of removing this and in the future, indeed, we can deprecate it few versions before.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Patch committed.

Plugins developers who are using @bcc_recipients@ setting must add their own setting starting from Redmine version:"5.0.0".
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,Closed,26791,Send individual notification mails per mail recipient
relates,Closed,30787,Other recipients are not listed in To field even if Setting.bcc_recipients is false
relates,Closed,8516,Email notifications without the recipient treated as attempted fraud by mail clients
relates,Closed,35957,MessagesControllerTest#test_post_new test fails (trunk)
blocks,Closed,31035,Remove redefinition of ActionMailer::LogSubscriber#deliver which is no longer necessary because of the removal of Setting.bcc_recipients