Vote #79926
完了Show projects using a table instead of an unordered list in the user profile page
0%
説明
I felt that the project list on the Profile page looks better 'table' style than 'ul' style. Especially on users with a large number of registered projects.
| 'ul' style|| 'table' style |
|!users-memberships-ul.png!| ==> |!users-memberships-table.png!|
journals
I made a patch and attached it.
--------------------------------------------------------------------------------
+1 Looks very clean.
I'll test it when I find a free time slot.
--------------------------------------------------------------------------------
Thank you for submitting the patch.
Takenori Takaki, I think it will be even better if subprojects are indented like admin/projects page. Is it possible?
!{width: 608px; border: 1px solid #ccc;}.projects-indented@2x.png!
--------------------------------------------------------------------------------
Maeda-san, Thank you for your feedback!
I also think that indented lists are better to see.
It is possible to indent in subprojects, by changing like the attached patch.
!users-memberships-indented-table.png!
--------------------------------------------------------------------------------
Thank you for the really nice improvement! But I encountered the following error while running test suites. Could you look into this?
<pre>
Failure:
UsersControllerTest#test_show_displays_memberships_based_on_project_visibility [/Users/maeda/redmines/redmine-trunk/test/functional/users_controller_test.rb:176]:
Expected at least 1 element matching "td:nth-of-type(1)>a", found 0..
Expected 0 to be >= 1.
bin/rails test test/functional/users_controller_test.rb:171
</pre>
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Thank you for the really nice improvement! But I encountered the following error while running test suites. Could you look into this?
>
Oops...Sorry...I could't notice the test broken.
I repaired the broken tests.
--------------------------------------------------------------------------------
LGTM. Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
I have slightly changed 31066-fix-broken-tests.patch.
* Use @Enumerable#group_by@ outside the loop in order to avoid using @Enumerable#select@ inside the loop. Maybe this is more efficient
* Remove "members" class from the table because "width: 45%" for td.roles looks too wide
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed. Thanks.
--------------------------------------------------------------------------------