Vote #79948: Update Rails to 5.2.3 - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #79948

完了

Update Rails to 5.2.3

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Rails support_44

対象バージョン:

4.0.4_151

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/31113

category_id:

version_id:

151

issue_org_id:

31113

author_id:

107353

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

https://weblog.rubyonrails.org/2019/3/28/Rails-5-2-3-has-been-released/

journals

Patch "here":https://gitlab.com/marius-balteanu/redmine/commit/b604a0c846f5e45bc57dca8790e5a91c255aea4d.diff.

If the tests pass (results "here":https://gitlab.com/marius-balteanu/redmine/-/jobs/185750691), I think we can deliver this in version:"4.0.3".
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Some tests fail: https://gitlab.com/marius-balteanu/redmine/-/jobs/185750691

<pre>
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F

Failure:
TimelogControllerTest#test_index_csv [/builds/marius-balteanu/redmine/test/functional/timelog_controller_test.rb:1361]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/timelog_controller_test.rb:1357

.............F

Failure:
TimelogControllerTest#test_index_csv_all_projects [/builds/marius-balteanu/redmine/test/functional/timelog_controller_test.rb:1353]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/timelog_controller_test.rb:1349

Failure:
TimelogReportTest#test_report_all_projects_csv_export [/builds/marius-balteanu/redmine/test/functional/timelog_report_test.rb:236]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/timelog_report_test.rb:227

...F

Failure:
TimelogReportTest#test_csv_cannot_convert_should_be_replaced_big_5 [/builds/marius-balteanu/redmine/test/functional/timelog_report_test.rb:337]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/timelog_report_test.rb:308

Failure:
TimelogReportTest#test_report_csv_export [/builds/marius-balteanu/redmine/test/functional/timelog_report_test.rb:254]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/timelog_report_test.rb:244

......F

Failure:
TimelogReportTest#test_csv_big_5 [/builds/marius-balteanu/redmine/test/functional/timelog_report_test.rb:292]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/timelog_report_test.rb:262

......F

Failure:
TimelogReportTest#test_csv_fr [/builds/marius-balteanu/redmine/test/functional/timelog_report_test.rb:372]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/timelog_report_test.rb:347

Failure:
IssuesControllerTest#test_index_csv_cannot_convert_should_be_replaced_big_5 [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:806]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:794

.....................F

Failure:
IssuesControllerTest#test_index_csv_with_spent_time_column [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:700]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:690

......F

Failure:
IssuesControllerTest#test_index_csv [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:642]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:636

...........................................................................F

Failure:
IssuesControllerTest#test_index_csv_with_all_columns [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:712]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:705

.........................................F

Failure:
IssuesControllerTest#test_index_csv_tw [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:830]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:818

....F

Failure:
IssuesControllerTest#test_index_csv_fr [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:848]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:836

...............................................................F

Failure:
IssuesControllerTest#test_index_csv_big_5 [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:784]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:773

Failure:
IssuesControllerTest#test_index_csv_with_description [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:684]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:672

....................................................................F

Failure:
IssuesControllerTest#test_index_with_relations_column [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:1316]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:1284

...F

Failure:
IssuesControllerTest#test_index_csv_with_project [/builds/marius-balteanu/redmine/test/functional/issues_controller_test.rb:656]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/issues_controller_test.rb:649

.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F

Failure:
UsersControllerTest#test_index_csv [/builds/marius-balteanu/redmine/test/functional/users_controller_test.rb:77]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/users_controller_test.rb:69

Failure:
UsersControllerTest#test_index_csv_with_name_filter [/builds/marius-balteanu/redmine/test/functional/users_controller_test.rb:99]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/users_controller_test.rb:93

Failure:
UsersControllerTest#test_index_csv_with_status_filter [/builds/marius-balteanu/redmine/test/functional/users_controller_test.rb:89]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/users_controller_test.rb:81

Failure:
UsersControllerTest#test_index_csv_with_group_filter [/builds/marius-balteanu/redmine/test/functional/users_controller_test.rb:107]:
Expected: "text/csv; header=present"
Actual: "text/csv"

bin/rails test test/functional/users_controller_test.rb:102
</pre>
--------------------------------------------------------------------------------
I think the test fails are generated by this change: https://github.com/rails/rails/pull/35549 and we need to update our tests to expect only “text/csv”.

Jean-Philippe, should we deliver this in 4.0.3?
--------------------------------------------------------------------------------
Here is the patch.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed the patch. Thanks.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

duplicates,Closed,31112,Update to Rails 5.2.3
blocks,Closed,31126,Update sqlite3 gem (~> 1.4.0)

操作

リンクをコピー

Admin Redmine さんが3年以上前に更新

カテゴリ を Rails support_44 にセット
対象バージョン を 4.0.4_151 にセット

編集操作

リンクをコピー

他の形式にエクスポート: Atom PDF

プロジェクト

全般

プロフィール

redmineorg-copy202205

カスタムクエリ

Vote #79948

Update Rails to 5.2.3

Admin Redmine さんが3年以上前に更新

編集

unofficial-redmine.org デモサイト¶

Redmine.org上のチケットplus1数を集計し、検索用に公開しています。( 2022/5 Redmine5.0 リリース記念版)¶