プロジェクト

全般

プロフィール

Vote #79985

完了

Replace jquery-rails with vanilla javascript ujs

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
127
issue_org_id:
31205
author_id:
107353
assigned_to_id:
332
comments:
6
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

When the migration to Rails 5.2 was made, the "Unobtrusive JavaScript" was reverted to jquery-rails instead of vanilla js (#26518 for more details).

Because we cannot stick for ever with the old jquery-rails library, I've updated the ui-rails to the latest version and fixed in the proper way #26518.

I propose to commit this patch as soon as possible in order to have enough time to find another possible issues (I've tested roughly other screens that are using the remote feature and I didn't find other problems).


journals

--------------------------------------------------------------------------------
I see the following error after applying the patch:

<pre>
Started GET "/javascripts/jquery-1.11.1-ui-1.11.0-ujs-5.2.3.js" for 127.0.0.1 at 2019-04-18 23:12:33 +0900

ActionController::RoutingError (No route matches [GET] "/javascripts/jquery-1.11.1-ui-1.11.0-ujs-5.2.3.js"):
</pre>
--------------------------------------------------------------------------------
Go MAEDA wrote:
> I see the following error after applying the patch:
>
> [...]

It is normal, I've attached an incomplete patch, sorry for that.

Please try the new one, it is zip because the patch size is greater than 600.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------
Please open new tickets for issues related to this change.
--------------------------------------------------------------------------------


related_issues

relates,Closed,26518,Rails 5: Adding a block in My Page causes "Invalid form authenticity token."

Admin Redmine さんが3年以上前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.1.0_127 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0