Vote #79994
完了Text may unexpectedly be enclosed in pre tags when an issue is created via HTML email
0%
説明
You sometimes see unexpected pre blocks if you create an issue by sending an HTML email. Please see the example below.
[Input]
foobar
[Expected]
!{width: 220px; border: 1px solid #ccc;}.expected-result@2x.png!
[Actual]
!{width: 220px; border: 1px solid #ccc;}.actual-result@2x.png!
This can be fixed by stripping preceding whitespaces from each line in the HTML.
diff --git a/lib/redmine/wiki_formatting/html_parser.rb b/lib/redmine/wiki_formatting/html_parser.rb
index 62445ff3b..b3b45f590 100644
--- a/lib/redmine/wiki_formatting/html_parser.rb
+++ b/lib/redmine/wiki_formatting/html_parser.rb
@@ -30,7 +30,7 @@ module Redmine
}
def self.to_text(html)
- html = html.gsub(/[\n\r]/, '').squeeze(' ')
+ html = html.gsub(/^\s+/, '').tr("\n\r", '').squeeze(' ')
doc = Loofah.document(html)
doc.scrub!(WikiTags.new(tags))
journals
Here is a patch with test code.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Fixed some issues in the patch.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------
related_issues
blocks,Closed,31231,Better handling of HTML tables when creating an issue from an email