Vote #80031
未完了Provide a way to automatically close all open subtasks too when a parent issue is being closed
0%
説明
I wish to add the function of reminder which shows up like pop-up screen to ask for closing the subtask when the parent issue is closed.
親チケットが閉じられたときに、子チケットを閉じるように求める、ポップアップ画面が表示されるようなリマインダー機能を追加してほしい。
journals
--------------------------------------------------------------------------------
Closing as a duplicate of #28492.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I don't think this issue is duplicate of #28492.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
This is POC.
There is no test.
You need apply #28492 patch first.
--------------------------------------------------------------------------------
Simplified.
--------------------------------------------------------------------------------
@$ LC_ALL=en_US.UTF-8 firefox@
!POC.png!
--------------------------------------------------------------------------------
This is new POC version.
There is still no test.
--------------------------------------------------------------------------------
This patch has test.
You need to apply #28492#note-14 patch first.
!issue-31322.ver.4.png!
--------------------------------------------------------------------------------
Previous patch uses complicated javascript.
This patch rewrite to use jQuery submit event.
Previous patch uses client html elements to check whether subtask is open or not.
So it cannot check invisible issue.
This patch uses ajax and check in server.
You need to apply #28492#note-14 patch first.
--------------------------------------------------------------------------------
This is additional patch to previous patch.
This patch replaces Javascript confirm dialog to ajax modal form.
!20191218-02-ajax-modal-form.png!
--------------------------------------------------------------------------------
This is additional patch to previous patch.
* All open subtasks are visible
* Selected status is allowed in all open subtasks
In this case this dialog opens.
!20191218-03-close-all-open-subtasks.png!
If not, previous note dialog opens.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Regarding Maruyama's patches, how about just #31589? It would be simple and clear.
--------------------------------------------------------------------------------
FWIW: This issue is not related/being superseded by either #28492 or #31589. See my explanation in #31589#note-21.
<code>@</code>Toshi MARUYAMA: It has become very hard to review your patches for this feature. Can you provide all your changes for this feature in a single patch and clearly specify which requirements it has (like a dependency on _an_ implementation for issue #28492)?
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> <code>@</code>Toshi MARUYAMA: It has become very hard to review your patches for this feature. Can you provide all your changes for this feature in a single patch and clearly specify which requirements it has (like a dependency on _an_ implementation for issue #28492)?
Done.
* attachment:20200131-series.diff has contains several revisions
* attachment:20200131-collapse.diff collapses attachment:20200131-series.diff revisions to one diff
These depend on #28492#note-20 issue-28492.ver.3.diff.
--------------------------------------------------------------------------------
Fix indents.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
r19803 changed ajax behavior and it broke previous patches.
These are fixed patches.
--------------------------------------------------------------------------------
related_issues
relates,Closed,31321,Option not to block closing a parent issue when its subtask is open
relates,New,28492,Option not to block closing a parent issue when it has open subtask(s)
relates,Closed,31589,Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)