Vote #80032
完了Allow to set is_private flag through a keyword in emails
0%
説明
Currently it is impossible to set the @is_private@ flag of an issue with an email keyword. The attached patch developed for "Planio":https://plan.io/redmine-hosting changes that.
The code will recognize yes/no values according to the users' and the default locale, as well as 0/1.
journals
Thank you for posting the patch. But the test fails.
<pre>
Failure:
MailHandlerTest#test_add_issue_with_private_keyword [test/unit/mail_handler_test.rb:507]:
Expected false to be truthy.
bin/rails test test/unit/mail_handler_test.rb:499
</pre>
I found the following line in log/test.log.
<pre>
MailHandler: missing information from John Smith: Unable to determine target project
</pre>
--------------------------------------------------------------------------------
My bad I admit I just ran the test against 3.4 (where it passed). I'll fix that tomorrow.
--------------------------------------------------------------------------------
here's the fixed patch - the test email was still tailored to Planio's customized mail handler which is why it failed on vanilla Redmine.
--------------------------------------------------------------------------------
The patch passed the test. Thanks!
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,8424,Add private issue option to receiving emails