Vote #80037
完了Do not lose content when updating a wiki page that has been renamed in the meantime
0%
説明
This is a corner case, but it happened recently with a client here at "Planio":https://plan.io/redmine-hosting.
When somebody renames a wiki page while somebody else is editing it, the latter will lose any updates to the content upon save due to the redirect performed by the @find_existing_or_new_page@ before action.
This patch adds an integration test that reproduces the behavior, and fixes it by replacing the before action with a simple call to @@wiki.find_or_new_page(params[:id])@ in @update@.
journals
--------------------------------------------------------------------------------
Setting the target version to 3.4.11.
--------------------------------------------------------------------------------
I had to change the name of the class WikiTest in @test/integration/wiki_test.rb@ to run @bin/rails test@ because it conflicts with the class WikiTest in @test/unit/wiki_test.rb@. I encountered the following error.
<pre>
/path/to/redmine/test/unit/wiki_test.rb:22:in `<top (required)>': superclass mismatch for class WikiTest (TypeError)
</pre>
Do you think what class name is appropriate?
--------------------------------------------------------------------------------
Oh well :) What about WikiIntegrationTest?
--------------------------------------------------------------------------------
Jens Krämer wrote:
> Oh well :) What about WikiIntegrationTest?
Looks nice!
--------------------------------------------------------------------------------
Committed the patch. Thank you for reporting and fixing this issue.
--------------------------------------------------------------------------------