Vote #80053
完了Bookmarks and recently used projects for the project jump box
0%
説明
This patch aims to make the project jump box (project selector in top right corner) more useful especially for installations / users with many projects.
- adds a bookmarking feature to the project overview page ** users can bookmark any project they have access to ** bookmarked projects will be rendered in a separate section in the jump box, on the top.
- the 3 most recently used projects will be rendered in a second section of the jump box. That number may be changed in the user's account preferences ** bookmarked projects are excluded from that list
- the last section of the jump box holds any other projects that would have been rendered in the jump box originally but are not already shown in one of the previous sections.
- all 3 sections will be filtered according to a given query string in the search box
- favorites and other projects lists are rendered as trees, recently used projects as a flat list ordered by time of last use
- recently used and bookmarked projects are stored as serialized arrays of project IDs in the user preferences.
!addbookmark.png!
!jumpbox.png!
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I like this change. Users generally be a member of many projects, but the projects they usually use is not so many. With this change, they can quickly go to the project they are currently working on.
--------------------------------------------------------------------------------
I've tried the patch and it makes project switching very fast and easy. A really great improvement for Redmine!
+1
--------------------------------------------------------------------------------
Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes.
<pre>
<code class="css">
.icon-bookmark { background-image: url(../images/tag_blue_delete.png); }
.icon-bookmark-off { background-image: url(../images/tag_blue_add.png); }
</code>
</pre>
--------------------------------------------------------------------------------
Bernhard Rohloff wrote:
> Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes.
>
> [...]
The icons are included in the patch. You can get them by using @git apply@ instead of @patch@ command.
--------------------------------------------------------------------------------
The patch looks very good to me. I'm in favour of delivering this feature in version:"4.1.0".
--------------------------------------------------------------------------------
I am sure that no one will dislike or oppose this feature. Let's deliver this feature in 4.1.0.
--------------------------------------------------------------------------------
Committed the patches. Thank you for contributing the great improvement.
--------------------------------------------------------------------------------
It does not work in production mode.
<pre>
Started GET "/" for 127.0.0.1 at 2019-05-21 09:26:20 +0900
Processing by WelcomeController#index as HTML
Current user: anonymous
Rendering welcome/index.html.erb within layouts/base
Rendered collection of news/_news.html.erb [2 times] (66.0ms)
Rendered welcome/index.html.erb within layouts/base (134.1ms)
Completed 500 Internal Server Error in 423ms (ActiveRecord: 14.2ms)
ActionView::Template::Error (uninitialized constant Redmine::ProjectJumpBox):
79: <%= hidden_field_tag(controller.default_search_scope, 1, :id => nil) if controller.default_search_scope %>
80: <label for='q'>
81: <%= link_to l(:label_search), {:controller => 'search', :action => 'index', :id => @project, :scope => default_search_project_scope}, :accesskey => accesskey(:search) %>:
82: </label>
83: <%= text_field_tag 'q', @question, :size => 20, :class => 'small', :accesskey => accesskey(:quick_search) %>
84: <% end %>
85: <%= render_project_jump_box %>
app/helpers/application_helper.rb:428:in `render_projects_for_jump_box'
app/helpers/application_helper.rb:478:in `render_project_jump_box'
app/views/layouts/base.html.erb:82:in `_app_views_layouts_base_html_erb__3861390146296937614_70221623652380'
lib/redmine/sudo_mode.rb:65:in `sudo_mode'
</pre>
--------------------------------------------------------------------------------
The following change fixes #31355#note-10.
<pre><code class="diff">
diff --git a/lib/redmine.rb b/lib/redmine.rb
index 805418d3d..7c06ac344 100644
--- a/lib/redmine.rb
+++ b/lib/redmine.rb
@@ -43,6 +43,7 @@ require 'redmine/field_format'
require 'redmine/menu_manager'
require 'redmine/notifiable'
require 'redmine/platform'
+require 'redmine/project_jump_box'
require 'redmine/mime_type'
require 'redmine/search'
require 'redmine/syntax_highlighting'
</code></pre>
--------------------------------------------------------------------------------
Committed the fix in #31355#note-10.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Do you have any plans to improve this patch to fix problem with many projects from #31908 ?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
An issue caused by this feature is reported as #32503.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> An issue caused by this feature is reported as #32503.
Fixed in r19325. The issue was that bookmarked and recently used projects are unexpectedly filtered by a search keyword after full-text search.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Any chance of getting Bookmarks on an issue level?
--------------------------------------------------------------------------------
Nothing happens when deleting a bookmark.
https://redmine.domain/projects/project/bookmark
ActionController::RoutingError (No route matches [GET] "/projects/project/bookmark"):
--------------------------------------------------------------------------------
related_issues
relates,Closed,31356,replace icon-fav with icon-user for 'my projects'
relates,Closed,31411,Internal Error (r18182)
relates,Closed,31508,Add missing frozen strings and copyrights
relates,Closed,32302,Filter projects after bookmarks
relates,Closed,572,My projects (or favourite projects)
relates,Closed,32503,Project jump box options are not extracted correctly after searching
relates,Closed,7751,Filter projects dropdown menu
relates,Closed,32944,Always preserve the tree structure in the project jump box
duplicates,Closed,7339,Add a favorites Project list.