Vote #80085
完了Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions
0%
journals
--------------------------------------------------------------------------------
Could you write the intention of this change?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Could you write the intention of this change?
Yes, it is the same as #24313 or #28605.
--------------------------------------------------------------------------------
Committed the patch. Thanks.
--------------------------------------------------------------------------------
I broke something, I'll add a patch to fix it later.
--------------------------------------------------------------------------------
Here are three more patches:
- attachment:0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
- attachment:0002-Use-icon-icon-classes-for-expandable-elements.patch and attachment:0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Here are three more patches:
> - attachment:0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
> - attachment:0002-Use-icon-icon-classes-for-expandable-elements.patch and attachment:0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.
Committed the patches. Thanks.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Here are three more patches:
> > - attachment:0001-Fix-missing-icons.patch fixes an issue introduced by me (r18204)
> > - attachment:0002-Use-icon-icon-classes-for-expandable-elements.patch and attachment:0003-Use-icon-icon-classes-for-sort-elements.patch add the "icon icon-*" classes to more elements.
>
> Committed the patches. Thanks.
Thanks! I'll take a look again to check if it's everything ok.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Collapsed/Expanded of filters and options in "Issues list, Spent time, Gantt, Calendar" do not worked using for IE11.
I think that maybe the toggleClass is the cause.
source:trunk/public/javascripts/application.js@18204#L75
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
The problem is caused by #3058 and it'll be fixed by the patch from #3058#note-96.
--------------------------------------------------------------------------------
I've just found 2 small issues where the expander icon is missing.
Project list:
!{width:50%;}.projects_list.png!
Permissions report:
!{width:50%;}.permissions_report.png!
Attached the fix.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I've just found 2 small issues where the expander icon is missing.
Confirmed the issues and committed the patch in r18897. Thanks.
--------------------------------------------------------------------------------
related_issues
relates,Closed,24313,Use the regular "icon icon-*" classes for all elements with icons
relates,Closed,28605,Add the missing icon class to the items with icons from the contextual menu
relates,Closed,31496,Switch between toggle plus and minus icons for toggle multi select
Admin Redmine さんが3年以上前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.1.0_127 にセット