Vote #80088
完了Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
0%
説明
Hi all,
I noticed that the associated revisions block is not places next to the comments section as it used to be. This happens when a user selects to display comments - In reverse chronological order option in /my/account. If it is set up to be displayed in chronological order everything looks just fine. I've attached a screenshot with shows the issue (this is the Purplemine theme here but it happen with the original one too).
mrliptontea from the Purplemine project found the root cause for this and wrote the following:
Aha! I found the cause - this happens when a user selects Display comments - In reverse chronological order option in /my/account. The same layout issue then happens with the default theme. This is because with reversed order the contextual menu is also displayed above the comment history, as defined in the template. Sorry but I'm afraid I can't fix this.
He marked the possible issue inside the redmine source code "here":https://github.com/redmine/redmine/blob/d646ec22cfd9b905688be010bf16c429bf31718f/app/views/issues/show.html.erb#L130-L139.
!Wrong_location_assisiated_revisions.png!
journals
Since the problem occurs only in the third-party theme, there is nothing we can do.
I hope the theme developer suggests how to update the Redmine's code to fix their issue.
--------------------------------------------------------------------------------
Hi,
thanks for the quick replay.
As I've wrote in the description is happens also with the default Redmine theme. See attached screenshot.
Mathias Buder wrote:
> Hi all,
>
> I noticed that the associated revisions block is not places next to the comments section as it used to be. This happens when a user selects to display comments - In reverse chronological order option in /my/account. If it is set up to be displayed in chronological order everything looks just fine. I've attached a screenshot with shows the issue (this is the Purplemine theme here but *it happen with the original one too*).
!https://www.redmine.org/attachments/download/23179/2019-05-26%2014_59_33-Window.png!
--------------------------------------------------------------------------------
I think it will be fixed if #3058 is merged to the trunk.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I think the attached patch fixes the issue.
*[Before]*
!{width: 764px; border: 1px solid #ccc;}.31438-before@2x.png!
*[After]*
!{width: 764px; border: 1px solid #ccc;}.31438-after@2x.png!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed the fix. Thank you for reporting this issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I am using Redmine 4.0.5 and I am still facing this issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,3058,Show issue history using tabs
relates,Closed,23518,Move action links and edit form above the history when displaying comments in reverse order
relates,New,32370,Action menu on issues details should not flip with the history order