Vote #80091
完了Add "<< me >>" option to user format issue custom fields
0%
説明
Currently, user format custom fields list member of the project, but "<< me >>" option which you can see in the Assignee field is not included in the list.
I think custom fields should have "<< me >>" option like the Assignee field for better usability and UI consistency.
journals
I attached a patch to add this feature.
Add "<< me >>" only when login user is included in the options.
!{width: 500px; border: 1px solid #ccc}result.png!
--------------------------------------------------------------------------------
LGTM. Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
confirmed.
I think there is no problem.
--------------------------------------------------------------------------------
akitani ryo wrote:
> confirmed.
> I think there is no problem.
Thank you for confirming!
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------
The test fails randomly.
<pre>
Failure:
Redmine::UserFieldFormatTest#test_possible_values_options_should_return_project_members_and_me_if_logged_in [/var/lib/jenkins/workspace/trunk/DATABASE_ADAPTER/sqlite3/RUBY_VER/ruby-2.6/test/unit/lib/redmine/field_format/user_field_format_test.rb:89]:
--- expected
+++ actual
@@ -1 +1 @@
-["<< me >>", "Dave Lopper", "John Smith"]
+["<< moi >>", "Dave Lopper", "John Smith"]
bin/rails test test/unit/lib/redmine/field_format/user_field_format_test.rb:84
</pre>
It can be fixed with the following patch.
<pre><code class="diff">
Index: test/unit/lib/redmine/field_format/user_field_format_test.rb
===================================================================
--- test/unit/lib/redmine/field_format/user_field_format_test.rb (リビジョン 18300)
+++ test/unit/lib/redmine/field_format/user_field_format_test.rb (作業コピー)
@@ -82,6 +82,7 @@
end
def test_possible_values_options_should_return_project_members_and_me_if_logged_in
+ ::I18n.locale = 'en'
User.current = User.find(2)
field = IssueCustomField.new(:field_format => 'user')
project = Project.find(1)
</code></pre>
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------