プロジェクト

全般

プロフィール

Vote #80108

完了

Switch between toggle plus and minus icons for toggle multi select

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
UI_10
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
10
version_id:
127
issue_org_id:
31496
author_id:
107353
assigned_to_id:
332
comments:
9
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

This patch:

fixes the existent behaviour where the same toggle plus icon is shown regardless multi select state

adds the "icon icon-*" classes

Before:
!{width:50%; border: 1px solid grey;}.before.png!

After:
!{width:50%; border: 1px solid grey;}.after.png!


journals

--------------------------------------------------------------------------------
Committed the patch. Thank you for fixing the behavior.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
An error in application.css was reported as #31502.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Please commit the attached fixes, the problem wasn't only the broken css rule.
--------------------------------------------------------------------------------
My last patch fixes:
- incorrect @icon-toggle-plus@ and @icon-toggle-minus@ background rules
- broken CSS rule in @.toggle-multiselect@ and removes some unnecessary rules
- some cases where clicking on toggle-multiselect element adds the icon class to "a" element instead of "span"
- icon switch in workflow permissions tab.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Please commit the attached fixes, the problem wasn't only the broken css rule.

Committed in r18224. Thanks.
--------------------------------------------------------------------------------


related_issues

relates,Closed,31328,Change the "+" button in the issues filter to a larger one
relates,Closed,31433,Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions
relates,Closed,31502,Error syntax in application.css

Admin Redmine さんが約4年前に更新

  • カテゴリUI_10 にセット
  • 対象バージョン4.1.0_127 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0