Vote #80122
完了CSV export of time entries report does not honor project filter
0%
説明
When exporting a report of time entries in a projet (from an URL like @/project/foo/time_entries/report@) the URL used (when the export options dialog is closed) is not the project specific URL (i.e. @/time_entries/report.csv@ and not @/project/foo/time_entries/report.csv@).
It seems the @report.csv@ is generated source:/trunk/app/views/timelog/report.html.erb@18146#L91 with
<%= report_time_entries_path(:format => 'csv') %>
and the original @form_tag@ source:/trunk/app/views/timelog/report.html.erb@18146#L91 uses
<%= form_tag(_report_time_entries_path(@project, nil), :method => :get, :id => 'query_form') do %>
journals
Thank you for sharing the probrem.
I have confirmed that the following changes solve the problem.
<pre><code class="diff">
diff --git a/app/views/timelog/report.html.erb b/app/views/timelog/report.html.erb
index ae64a891e1..24425a55d0 100644
--- a/app/views/timelog/report.html.erb
+++ b/app/views/timelog/report.html.erb
@@ -88,8 +88,8 @@
$(document).ready(function(){
$('input#csv-export-button').click(function(){
$('form input#encoding').val($('select#encoding option:selected').val());
- $('form#query_form').attr('action', '<%= report_time_entries_path(:format => 'csv') %>').submit();
- $('form#query_form').attr('action', '<%= report_time_entries_path %>');
+ $('form#query_form').attr('action', '<%= _report_time_entries_path(@project, nil, :format => 'csv') %>').submit();
+ $('form#query_form').attr('action', '<%= _report_time_entries_path(@project, nil) %>');
hideModal(this);
});
});
</code></pre>
--------------------------------------------------------------------------------
Here is a patch for this issue (its tracker may be changed).
Tests done :
* Export from "/time_entries/report"
→ uses "/time_entries/report.csv"
* Export from "/project/foo/time_entries/report"
→ uses "/project/foo/time_entries/report.csv"
--------------------------------------------------------------------------------
Setting the target version to 4.0.4.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed the fix. Thank you for reporting and fixing this issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,26279,Allow switching the encoding to UTF-8 when exporting to CSV
duplicates,Closed,30809,Spent time report > CSV not obeying filters