Vote #80167
完了Add clear query icon next to selected query in sidebar
0%
説明
Now that "All issues" link was removed from the sidebar, we should have an easier way in sidebar to clear the current query.
My proposal is to add a Clear link next to selected query link:
!{width:50%; border: 1px solid black;}.clear_query.png!
On hover:
!{width:50%; border: 1px solid black;}.clear_query_hover.png!
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Fixed some Rubocop warnings.
--------------------------------------------------------------------------------
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/68625213
--------------------------------------------------------------------------------
Although I understand the reason why you use !/images/reload.png! (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to !/images/close.png! (close.png).
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Although I understand the reason why you use !/images/reload.png! (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to !/images/close.png! (close.png).
Agree, but !/images/close.png! (close.png) icon is not so visible:
!clear_with_close.png!
Attached the updated patch. Go Maeda, if you have a better idea, please fell free to update my patch.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Agree, but !/images/close.png! (close.png) icon is not so visible:
Using !/images/close_hl.png! (close_hl.png) looks nicer.
!clear_with_close_hl@2x.png!
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Agree, but !/images/close.png! (close.png) icon is not so visible:
>
> Using !/images/close_hl.png! (close_hl.png) looks nicer.
Indeed, close_hl.png is better.
Regarding the patch, you have attached a wrong one.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Regarding the patch, you have attached a wrong one.
Sorry, here is the correct patch.
--------------------------------------------------------------------------------
Committed the patch. Thank you for improving Redmine.
--------------------------------------------------------------------------------
related_issues
relates,Closed,30294,Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown