プロジェクト

全般

プロフィール

Vote #80180

完了

Add missing fixtures to AttachmentFormatVisibilityTest

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
127
issue_org_id:
31705
author_id:
362529
assigned_to_id:
332
comments:
1
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

The test has failed.
https://www.redmine.org/builds/logs/build_trunk_sqlite3_ruby-2.6_456.html

E

Error:
AttachmentFormatVisibilityTest#test_attachment_should_be_visible_with_visible_custom_field:
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALUES (?, ?)
    test/object_helpers.rb:204:in `generate!'
    test/object_helpers.rb:209:in `generate!'
    test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb:36:in `test_attachment_should_be_visible_with_visible_custom_field'

bin/rails test test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb:35

E

Error:
AttachmentFormatVisibilityTest#test_attachment_should_be_visible_with_limited_visibility_custom_field:
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALUES (?, ?)
    test/object_helpers.rb:204:in `generate!'
    test/object_helpers.rb:209:in `generate!'
    test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb:50:in `test_attachment_should_be_visible_with_limited_visibility_custom_field'

bin/rails test test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb:49

I think that because the fixtures is not enough.


diff --git a/test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb b/test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb
index b648ac11f..c9fee583a 100644
--- a/test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb
+++ b/test/unit/lib/redmine/field_format/attachment_format_visibility_test.rb
@@ -25,6 +25,7 @@ class AttachmentFormatVisibilityTest < ActionView::TestCase
            :roles, :members, :member_roles,
            :users, :email_addresses,
            :trackers, :issue_statuses, :enumerations, :issue_categories,
+           :custom_fields, :custom_fields_trackers,
            :versions, :issues

   def setup

journals

Committed the patch. Thank you.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.1.0_127 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0