Vote #80231
完了Remove deprecated .zIndex() method
0%
説明
Système : Debian 10
Redmine version : 4.0.1-2
libjs-jquery-ui version : 1.12.1+dfsg-5
.zIndex() method is deprecated from jQuery UI
https://jqueryui.com/upgrade-guide/1.12/#removed-zindex
.zIndex() is used in public/javascript/application.js
https://www.redmine.org/projects/redmine/repository/entry/branches/4.0-stable/public/javascripts/application.js
lines 429, 439
problem occurs when adding member to a project.
proposed correction :
function showModal(id, width, title) {
var el = $('#'+id).first();
if (el.length === 0 || el.is(':visible')) {return;}
if (!title) title = el.find('h3.title').text();
// moves existing modals behind the transparent background
- $(".modal").zIndex(99);
+ $(".modal").css('zIndex',99);
el.dialog({
width: width,
modal: true,
resizable: false,
dialogClass: 'modal',
title: title
}).on('dialogclose', function(){
- $(".modal").zIndex(101);
+ $(".modal").css('zIndex',101);
});
el.find("input[type=text], input[type=submit]").first().focus();
}
journals
Related URLs:
* https://github.com/jquery/jquery-ui/commit/faf87d992455280182edef015c8733313744a739
* https://jqueryui.com/upgrade-guide/1.11/#deprecated-zindex
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Hi, already asked this in Defect #31708, there is a "close" text on the close button, any way to remove it? Appreciate any answer.
--------------------------------------------------------------------------------
related_issues
relates,Closed,31196,Updates jQuery to 2.2.4 and adds jQuery Migrate library
relates,Closed,31708,Not able to add member to a project
blocks,Closed,31887,Update jQuery UI to 1.12.1
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.0.5_153 にセット