--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1!!
--------------------------------------------------------------------------------
note: jQuery 1.x and 2.x was already EOL. See below.

* https://github.com/jquery/jquery.com/issues/162
--------------------------------------------------------------------------------
Here is a patch that updates jQuery UI to latest version (1.12.1). The patch is zip archive because of the size.

Among all the changes, the new version of jQuery UI brings a new default theme ("Smoothness":https://jqueryui.com/upgrade-guide/1.12/#new-default-theme) and "Font size changes":https://jqueryui.com/upgrade-guide/1.12/#font-size-changes which do not require anymore some overrides made in Redmine theme.

Beside the update, the patch removes those overrides, adds a new overlay background and makes the autocomplete to have the same look and feel from inline auto complete, context menu or quick project.

Also, starting with this version, the library is divided in multiple components and we can decrease the size of it if we drop those components not used by Redmine, but the change can affect plugin developers.

--------------------------------------------------------------------------------
Some screenshots.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Sho HASHIMOTO wrote:
> note: jQuery 1.x and 2.x was already EOL. See below.
>
> * https://github.com/jquery/jquery.com/issues/162

Here we track jQuery UI update and in #33383 we track jQuery.

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Here is a patch that updates jQuery UI to latest version (1.12.1). The patch is zip archive because of the size.

Thank you for working on this. Features that depend on JQuery UI such as dialogs and auto-completes seem to be working fine.
--------------------------------------------------------------------------------
Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Also, starting with this version, the library is divided in multiple components and we can decrease the size of it if we drop those components not used by Redmine, but the change can affect plugin developers.

Dropping some components is a big change, so I think it is better to put off the change until Redmine 5.0.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Also, starting with this version, the library is divided in multiple components and we can decrease the size of it if we drop those components not used by Redmine, but the change can affect plugin developers.
>
> Dropping some components is a big change, so I think it is better to put off the change until Redmine 5.0.

Agree.
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------
The style of the highlighted code listings on the Wiki toolbar has changed since this change was committed.
The background color of the li element does not change when hovering.

!{width: 70%; border: 1px solid #ccc}ScreenShot-2020-05-14-11.21.34.png!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
> The style of the highlighted code listings on the Wiki toolbar has changed since this change was committed.
> The background color of the li element does not change when hovering.

Reverted r19769 in r19776.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Here is the patch to fix the reported issue, thanks for pointing this out. I didn't know that the JS Toolbar depends on the menu component from jQuery UI (issue "cause":https://jqueryui.com/upgrade-guide/1.12/#require-wrappers-for-each-menu-item). We should drop this dependency in the future.

@Go Maeda, I don't think that it's necessary to revert the changes, we're on trunk and for the patches that I work on, I will provide fixes as soon as I can.
--------------------------------------------------------------------------------
Committed the patch again with attachment:0002-Fix-JS-languages-menu-style.patch. Thank you.

> @Go Maeda, I don't think that it's necessary to revert the changes, we're on trunk and for the patches that I work on, I will provide fixes as soon as I can.

I thought it was a rather serious issue. And I didn't expect the issue is fixed so quickly. But now I think that reverting r19769 was too early.
--------------------------------------------------------------------------------

blocks,Closed,31870,Remove deprecated .zIndex() method
blocks,Closed,32125,Issues autocomplete may not find issues with a subject longer than 60 characters