Vote #80254: Require 2FA only for certain user groups - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80254

完了

Require 2FA only for certain user groups

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Accounts / authentication_7

対象バージョン:

5.0.0_155

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/31920

category_id:

version_id:

155

issue_org_id:

31920

author_id:

40856

assigned_to_id:

107353

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

This patch, which should be applied on top of those from #1237, adds a flag to groups so 2FA can be globally optional, but required for certain groups of users.

journals

--------------------------------------------------------------------------------
I have rebased this patch in order to deliver this feature together with #1237. All tests pass after I've fixed the rubocop warnings.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I've updated the patch for the current trunk and I made two changes:
1. Remove the empty @setup do end@ from @test/integration/twofa_test.rb@
2. Added a check in @app/view/groups/_form.html.erb@ in order to not diplay the "Require two factor authentication" field for builtin groups (Anonymous and Non Member) because the option won't make any sense for those groups.

@Jens Krämer, please take a look over my changes, I would like to commit this as soon as possible if the changes look good to you.
--------------------------------------------------------------------------------
looks good to me!
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.

--------------------------------------------------------------------------------

related_issues

relates,Closed,35086,Please consider changing the way how 2FA is set up
relates,Closed,35439,Option to require 2FA only for users with administration rights
blocks,Closed,1237,Add support for two-factor authentication