Vote #80258: MarkdownFormatterTest#test_should_support_underlined_text is declared as private - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80258

完了

MarkdownFormatterTest#test_should_support_underlined_text is declared as private

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

4.1.0_127

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/31929

category_id:

version_id:

127

issue_org_id:

31929

author_id:

1565

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

#28169 introduced @Redmine::WikiFormatting::MarkdownFormatterTest#test_should_support_underlined_text@. However, this test seems to be unintentionally declared as private instead of being public due to the existence of the private method @#assert_section_with_hash@.

This issue was reported by Martin Cizek in issue #22323#note-5.

journals

--------------------------------------------------------------------------------
It was introduced by me in #28169. Attached a patch with the fix.
--------------------------------------------------------------------------------
Setting the target version to 4.0.5.
--------------------------------------------------------------------------------
Committed the patch. Thanks.

I don't think we have to backport this change to 4.0-stable because the issue does not affect users.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,Closed,28169,Enable and add underline button to the toolbar for Markdown formatting
relates,Closed,33562,Some tests in ApplicationHelperTest are declared as private