プロジェクト

全般

プロフィール

Vote #80264

完了

ThemesTest may fail if a third-party theme with a favicon is installed

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
127
issue_org_id:
31941
author_id:
332
assigned_to_id:
332
comments:
5
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Steps to reproduce:

  1. Add a theme with the name 'xyz'.

    cp -r public/themes/alternate public/themes/xyz
    mkdir public/themes/xyz/favicon
    cp public/favicon.ico public/themes/xyz/favicon/
    
  2. Run the test.


    $ bin/rails test test/integration/lib/redmine/themes_test.rb
    Run options: --seed 6694

Running:

.F

Failure:
ThemesTest#test_use_only_one_theme_favicon_if_theme_provides_many [/Users/maeda/redmines/redmine-trunk/test/integration/lib/redmine/themes_test.rb:85]:
Expected at least 1 element matching "link[rel="shortcut icon"][href="/themes/xyz-theme/favicon/b.ico"]", found 0..
Expected 0 to be >= 1.

bin/rails test test/integration/lib/redmine/themes_test.rb:79

.F

Failure:
ThemesTest#test_use_default_favicon_if_theme_provides_none [/Users/maeda/redmines/redmine-trunk/test/integration/lib/redmine/themes_test.rb:65]:
Expected at least 1 element matching "link[rel="shortcut icon"][href="/favicon.ico"]", found 0..
Expected 0 to be >= 1.

bin/rails test test/integration/lib/redmine/themes_test.rb:61

F

Failure:
ThemesTest#test_use_theme_favicon_if_theme_provides_one [/Users/maeda/redmines/redmine-trunk/test/integration/lib/redmine/themes_test.rb:74]:
Expected at least 1 element matching "link[rel="shortcut icon"][href="/themes/xyz-theme/favicon/a.ico"]", found 0..
Expected 0 to be >= 1.

bin/rails test test/integration/lib/redmine/themes_test.rb:68

F

Failure:
ThemesTest#test_with_sub_uri [/Users/maeda/redmines/redmine-trunk/test/integration/lib/redmine/themes_test.rb:100]:
Expected at least 1 element matching "link[rel="shortcut icon"][href="/foo/themes/xyz-theme/favicon/a.ico"]", found 0..
Expected 0 to be >= 1.

bin/rails test test/integration/lib/redmine/themes_test.rb:91

.

Finished in 2.641204s, 2.6503 runs/s, 6.4365 assertions/s.
7 runs, 17 assertions, 4 failures, 0 errors, 0 skips


journals

Here is a patch to fix this issue.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Removed a hard-coded theme name from the previous patch.
--------------------------------------------------------------------------------
Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
Committed.
--------------------------------------------------------------------------------


related_issues

relates,Closed,25118,ThemesTest#test_without_theme_js may fail if third-party theme is installed

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.1.0_127 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0