Vote #80299: Rounded corners of the main menu - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80299

完了

Rounded corners of the main menu

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

UI_10

対象バージョン:

4.1.0_127

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/32013

category_id:

version_id:

127

issue_org_id:

32013

author_id:

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

Most UI elements of Redmine are now rounded, it feels like main menu should too.

journals

!roundedmenu.png!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1 IMHO it looks very nice and polished. It fits nicely into the design of the other tab menus.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
LGTM. Setting the target version to 4.1.0.

Bernhard Rohloff wrote:
> It fits nicely into the design of the other tab menus.

Indeed. Tabs in the project settings page and the administration page already have rounded corner. Tabs in the project menu should have rounded corner as well in order to make the appearance consistent.

--------------------------------------------------------------------------------
Committed the patch. Thank you for the nice improvement.
--------------------------------------------------------------------------------
I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the previous patch as the border radius can be set in one place.

!menu-children-border-radius.png!
--------------------------------------------------------------------------------
Bernhard Rohloff wrote:
> I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the previous patch as the border radius can be set in one place.

Thanks for the heads up, I already did a fix to this in #32100 but I guess Bernhard's version of this patch here is a bit better, so I will update the second patch in #32100 to bounce off the new circumstances as well :D

I think we should add #32100 as related to this ticket.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Antonio McDeal wrote:

> ... I already did a fix to this in #32100 but I guess Bernhard's version of this patch here is a bit better, so I will update the second patch in #32100 to bounce off the new circumstances as well :D

Oh sorry, I didn't noticed that...

> I think we should add #32100 as related to this ticket.
done ;-)

--------------------------------------------------------------------------------
Go, would it be possible to commit Bernhard's fix? I tested it, works well ;-)
--------------------------------------------------------------------------------
Bernhard Rohloff wrote:
> I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too.

Committed the fix attachment:fixed-menu-children-border-radius.diff in r18543. Thanks.
--------------------------------------------------------------------------------

related_issues

relates,Closed,32015,Rounded corners of "my page" blocks
relates,Closed,32014,Rounded corners on table.list elements
relates,New,32016,Rounded coreners on roadmap's progress bar
relates,New,32100,Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements