Vote #80321
完了Add test for 4 byte characters (emoji) support
0%
説明
In #31921 was added proper support for 4 byte characters (emoji) for new installations with MySQL as database.
I proposed to have a test for this case, but we're worried that the test will broke the CI server.
The scope of this ticket is to fix the CI server if the MySQL is not already configured properly by recreating the database with utf8mb4 encoding.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I have already added Emoji test (r19699).
git_urf8 test repository is not extracted due to this.
https://www.redmine.org/builds/logs/build_trunk_mysql_ruby-2.6_1044.html
<pre>
+ PATH=/var/lib/jenkins/ruby/ruby-2.6/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:
/usr/games SCMS=subversion,git,mercurial,filesystem,bazaar,cvs
bundle exec rake ci:about ci:setup db:environment:set RAILS_ENV=test
</pre>
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I proposed to have a test for this case, but we're worried that the test will broke the CI server.
I think we can avoid errors occurring on the CI server by adding the following check at the beginning of the test.
<pre><code class="ruby">
skip if Redmine::Database.mysql? && !is_mysql_utf8mb4
</code></pre>
I will commit attachment:test_for_emoji_support-v2.patch soon.
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------
related_issues
relates,Closed,31921,Changes to properly support 4 byte characters (emoji) when database is MySQL
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.2.0_152 にセット