Vote #80359
完了Repository browser does not render previews for audio/video files
0%
説明
#27336 added preview for audio/video files to attachments and repositories, however, audio/video preview for repositories is not working. It always shows "No preview available" message for all kind of audio/video files.
!{width: 914px; border: 1px solid #ccc;}.no-preview-available@2x.png!
journals
--------------------------------------------------------------------------------
Attaching a quick-and-dirty workaround.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Attaching a quick-and-dirty workaround.
Thanks :-)
I'll share more feedback after I test it if I'll find more bugs
--------------------------------------------------------------------------------
Update: this seems to be working with no problems so far, if somebody else could double check it for security sake, it would be a really cool fix to commit ;-)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
If you need tests to commit 32153-workaround.patch, add tests based on the attached patch.
* 0002-Add-test.patch is a patch that should be applied after 32153-workaround.patch is applied
* 0002-Add-test.patch adds a .mp4 file to the test subversion_repository.
** _rake test:scm:update_ command must be executed after applying the patch for the test to succeed
--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
> If you need tests to commit 32153-workaround.patch, add tests based on the attached patch.
Thanks. Setting the target version to 4.1.1.
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,27336,Render previews for audio and video files