Vote #80382: Calendar page lacks buttons to manage custom queries - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80382

完了

Calendar page lacks buttons to manage custom queries

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Calendar_36

対象バージョン:

4.2.0_152

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/32194

category_id:

version_id:

152

issue_org_id:

32194

author_id:

332

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

You can apply existing custom queries to Calendar but you cannot create, edit, or delete custom queries on the Calendar page because the page lacks "Save", "Edit", or "Delete" buttons for queries.

Like Issues and Gantt, the Calendar page should also have those buttons.

!{width: 824px; border: 1px solid #ccc;}.no-save-button@2x.png!

!{width: 824px; border: 1px solid #ccc;}.no-edit-and-delete-buttons@2x.png!

journals

I attach a patch to add "Save", "Edit" and "Delete" buttons(0001~).

The 0002 patch corrects the indentation of corrects app/views/queries/_form.html.erb.
Since the buttons are only added by the 0001 patch, it is not mandatory to commit the 0002 patch.
--------------------------------------------------------------------------------
Setting the target version to 4.2.0.

This patch conflicts with #23980. I don't commit this patch now in order to prioritize #23980.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Go MAEDA wrote:
> This patch conflicts with #23980. I don't commit this patch now in order to prioritize #23980.

Since #23980 was postponed until 5.0.0, I think this fix can be committed now.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Go MAEDA wrote:
> > This patch conflicts with #23980. I don't commit this patch now in order to prioritize #23980.
>
> Since #23980 was postponed until 5.0.0, I think this fix can be committed now.

I think the patches conflicts with #29482 and not with #23980. Right now, only the first patch can be applied cleanly on the current trunk.
--------------------------------------------------------------------------------
I modified the patch so that it can be applied cleanly to the current trunk.
--------------------------------------------------------------------------------
Thank you for updating the patch. Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------