Vote #80483: Layout of the custom field edit page is different between the single edit page and the batch edit page - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80483

完了

Layout of the custom field edit page is different between the single edit page and the batch edit page

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Issues_2

対象バージョン:

4.2.0_152

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/32471

category_id:

version_id:

152

issue_org_id:

32471

author_id:

429845

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

If you select and edit multiple issues, the custom fields are arranged vertically.
On the other hand, if you select and edit one issue, the custom field is divided into left and right.

single editing:
!single_edit.png!

multiple editing(Before fix):
!bulk_edit_before_fix.png!

Applying this patch will cause the custom field to be split into left and right for multiple edits in Issue.

multiple editing(After fix):
!bulk_edit_after_fix.png!

The attached patch implements this feature.

journals

The patch changes the logic for rendering custom fields in bulk edit page to be the same as in app/views/issues/_form_custom_fields.html.erb.

I think it improves consistency.
--------------------------------------------------------------------------------
It is just as you say.
Modify app/views/issues/bulk_edit.html.erb and app/views/issues/_form_custom_fields.html.erb to reduce duplication.
--------------------------------------------------------------------------------
Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
I think full-width custom fields need to be considered in the bulk edit page.

*Editing a single issue:*
!{border: 1px solid grey; width: 747px;}.single-edit-layout@2x.png!

*Bulk edit:*
!{border: 1px solid grey; width: 924px;}.bulk-edit-layout@2x.png!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I've attached 3 patches that fix the problem reported here and also, adds the JS toolbar in this page for full width custom fields with text formatting enabled. Should some fixes made here backported to minor versions?
--------------------------------------------------------------------------------
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/132967327
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed the patch series. Thank you.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

blocks,Closed,33256,Show wiki toolbar for spent time custom fields with text formatting enabled
blocks,Closed,33255,Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page