プロジェクト

全般

プロフィール

Vote #80558

未完了

Adding an empty reply to a forum message does not show any error

Admin Redmine さんが約3年前に追加. 約3年前に更新.

ステータス:
New
優先度:
通常
担当者:
-
カテゴリ:
Forums_5
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
5
version_id:
32
issue_org_id:
32664
author_id:
332
assigned_to_id:
0
comments:
4
status_id:
1
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[New]

説明

Steps to reproduce:

  1. Open any forum topic and click "Reply"
  2. Attach any file and click "Submit"
  3. You will see "Successful update" message but the reply is not added. The attachment is silently discarded

Expected behavior:

"Content cannot be blank" error should be shown.


journals

Show any error message when submitting a reply. I attached a patch.
However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.

!{width:600px;border:1px solid #ccc;}show_any_error_when_reply.png!
--------------------------------------------------------------------------------
Yuichi HARADA wrote:
> However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.

You are right. Thank you for pointing it out.

And I found that the behavior that showing an error is not consistent with issues. When updating issues, no error is shown even if note is empty. Its behavior is similar to forums but the only difference is the behavior when adding attachments with an empty note. In the case, attachments are added to the issue.

I think the following behavior is better for forums. It is consistent with the behavior of issues.

* Empty message _without_ attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown
* empty message _with_ attachments: Attach the files instead of discarding them

--------------------------------------------------------------------------------
Go MAEDA wrote:
> I think the following behavior is better for forums. It is consistent with the behavior of issues.
>
> * Empty message _without_ attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown
> * empty message _with_ attachments: Attach the files instead of discarding them

Thank you for pointing it out. I attached a patch that incorporates the above behaviors.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

Admin Redmine さんが約3年前に更新

  • カテゴリForums_5 にセット
  • 対象バージョンCandidate for next major release_32 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0