Vote #80585: Tabs are displayed on two lines when the total width of the tabs is greater than 2000px - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80585

完了

Tabs are displayed on two lines when the total width of the tabs is greater than 2000px

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

UI_10

対象バージョン:

4.0.7_159

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/32772

category_id:

version_id:

159

issue_org_id:

32772

author_id:

115781

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

New tab based history has issue with drawing tab frames.

!frame_issue.png!
Tested on Chrome and IE.

Environment:
  Redmine version                4.1.0.stable
  Ruby version                   2.5.7-p206 (2019-10-01) [x64-mingw32]
  Rails version                  5.2.4.1
  Environment                    production
  Database adapter               Mysql2
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
SCM:
  Subversion                     1.11.1
  Git                            2.19.1
  Filesystem                     
Redmine plugins:
  no plugin installed

journals

I cannot reproduce, tried on OS Catalina with Chrome (latest) and Windows with Chrome (latest), Edge 17 and 18. Attached some screenshots.

Can you try a hard reload in Chrome or incognito?
--------------------------------------------------------------------------------
I have retried with:
* Chrome 79.0.3945.79, also in incognito.
* IE 11.1087
* Edge 41 / EdgeHTML 16

In both cases I use Alternate theme.

I have noticed this is dependent on the windows width and shows up above ~2400 pixels.
--------------------------------------------------------------------------------
Sebastian Paluch wrote:
> In both cases I use Alternate theme.

I think the theme you are using is not Alternate. The line at the bottom of the note header ("Updated by xxxxx ...") is not displayed with Alternate theme.

Could you try with "genuine" Alternate theme?

!{border: 1px solid #ccc;}.alternate-theme.png!
--------------------------------------------------------------------------------
Go MAEDA wrote:
> I think the theme you are using is not Alternate. The line at the bottom of the note header ("Updated by xxxxx ...") is not displayed with Alternate theme.
>
The issue exists with Alternate theme.
!alternate.png!

With classic it looks this way
!classic.png!

--------------------------------------------------------------------------------
I can reproduce the issue by pulling the browser window over my two low resolution monitors.
It's because the `ul` container inside the tabs class is hard set to 2000px.
The attached patch should fix the problem.

@Sebastian Paluch can you double check that the problem is gone after applying the patch?
--------------------------------------------------------------------------------
Bernhard Rohloff wrote:
> @Sebastian Paluch can you double check that the problem is gone after applying the patch?

Yes, the patch fixes the issue with not drawing the line at the end (highlighted with red at the right side).

I don't know though what was the design intent about horizontal and vertical lines. They not getting together, they are not closing the frame (highlighted with red on the left side). Frames in other places are closed, therefore this looks like an issue.
--------------------------------------------------------------------------------
Thanks Bernhard for finding the cause of the issue and for the fix. I remember now that the issue reproduces also on Settings page (or other page with tabs) when the total width of the tabs is greater than 2000px.

!settings.png!

I'm assigning this to version:"4.0.7".

Sebastian Paluch wrote:
> I don't know though what was the design intent about horizontal and vertical lines. They not getting together, they are not closing the frame (highlighted with red on the left side). Frames in other places are closed, therefore this looks like an issue.

Is the expected design, please see #26662, but I agree with you that it looks strange. I've proposed in #31573 another design for journal entries, maybe you can add your feedback there.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed the patch. Thank you all for investigating and fixing this issue.
--------------------------------------------------------------------------------