Vote #80604
完了Clean up toggleMultiSelect js function
0%
説明
The attached patch cleans up toggleMultiSelect function(attachment:toggle_multiple_select.gif).
- 0001. Unify the process to toggleMultiSelect written in "workflows/permissions":https://redmine.org/projects/redmine/repository/revisions/19430/entry/trunk/app/views/workflows/edit.html.erb#L63, "workflows/edit":https://redmine.org/projects/redmine/repository/revisions/19430/entry/trunk/app/views/workflows/permissions.html.erb#L111, and "query_filter":https://redmine.org/projects/redmine/repository/revisions/19430/entry/trunk/public/javascripts/application.js#L338 respectively
- 0002. Fix "app/controllers/workflows_controller.rb":https://redmine.org/projects/redmine/repository/revisions/19430/entry/trunk/app/controllers/workflows_controller.rb#L127 that should have changed along with #15988 (It works like attachment:toggle_role_selectbox.gif due to the problem)
journals
--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
> * 0002. Fix "app/controllers/workflows_controller.rb":https://redmine.org/projects/redmine/repository/revisions/19430/entry/trunk/app/controllers/workflows_controller.rb#L127 that should have changed along with #15988
> (It works like attachment:toggle_role_selectbox.gif due to the problem)
I think it is another issue. It is not a code cleanup but a bug. I think it should be handled by another new issue. What do you think?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Mizuki ISHIKAWA wrote:
> > * 0002. Fix "app/controllers/workflows_controller.rb":https://redmine.org/projects/redmine/repository/revisions/19430/entry/trunk/app/controllers/workflows_controller.rb#L127 that should have changed along with #15988
> > (It works like attachment:toggle_role_selectbox.gif due to the problem)
>
> I think it is another issue. It is not a code cleanup but a bug. I think it should be handled by another new issue. What do you think?
I created a issue reporting the bug and attached a patch. #33059
--------------------------------------------------------------------------------
Setting the target version to 4.2.0.
Since attachment:0002-Fix-roles.patch has already been committed in r19538, the patch to be committed is only attachment:0001-Unify-processing-for-switching-multiple-selections.patch.
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 4.2.0_152 にセット