プロジェクト

全般

プロフィール

Vote #80633

完了

Fix violations reported by Stylelint

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
152
issue_org_id:
32890
author_id:
107353
assigned_to_id:
332
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Linting the CSS files using the rules proposed in #32888 generates the following violations:

root@df2fd1389bf4:/work# node_modules/.bin/stylelint "public/stylesheets/**/*.css"

public/stylesheets/application.css
  561:1   ✖  Unexpected duplicate selector "div#issue-changesets div.changeset", first used at line 560   no-duplicate-selectors                   
  682:77  ✖  Unexpected duplicate "pre"                                                                   declaration-block-no-duplicate-properties
 1084:1   ✖  Unexpected duplicate selector "table.progress", first used at line 1075                      no-duplicate-selectors                   
 1560:1   ✖  Unexpected duplicate selector ".sort-handle", first used at line 706                         no-duplicate-selectors                   
 1619:83  ✖  Unexpected duplicate "color"                                                                 declaration-block-no-duplicate-properties

public/stylesheets/responsive.css
 264:18  ✖  Unexpected missing generic font family                                                                                                  font-family-no-missing-generic-family-keyword
 804:3   ✖  Unexpected duplicate selector "#issue_tree .issue > td:not(.checkbox), #relations .issue > td:not(.checkbox)", first used at line 787   no-duplicate-selectors                       
 828:3   ✖  Unexpected duplicate selector "#issue_tree .issue > td.subject,   #relations .issue > td.subject", first used at line 799               no-duplicate-selectors                       

public/stylesheets/rtl.css
 322:21  ✖  Unexpected duplicate "margin-right"   declaration-block-no-duplicate-properties
 377:14  ✖  Unexpected empty block                block-no-empty

The attached patches fix all of them with one exception @828:3 ✖ Unexpected duplicate selector "#issue_tree .issue > td.subject, #relations .issue > td.subject", first used at line 799 no-duplicate-selectors@ which should be fixed by #32889.


journals

Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
Committed the patches. Thank you.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

relates,Closed,32888,Use stylelint to avoid errors and enforce conventions in CSS files

Admin Redmine さんが3年以上前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.2.0_152 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0