Vote #80671
完了Fix selected user on log time edit page when user has permissions to log time for another user
0%
説明
when you're editing a existing timelog entry and have the rights to adjust the user ( or log on behalf of another user ), the current value will not be selected in the drop down due to this line:
the fix is quite simple, just drop the @.to_s@
selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id == selected
and its working.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index b40f42ecc..e13825082 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -575,7 +575,7 @@ module ApplicationHelper
end
groups = +''
collection.sort.each do |element|
- selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id == selected
+ selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id.to_s == selected
(element.is_a?(Group) ? groups : s) << %()
end
unless groups.empty?
journals
missed the selected version, this applies to @4.1-stable@
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Thanks easter egg for detecting the issue.
I have attached a patch that fixes the code added in #3848 and adds a test for this case. Regarding your fix from @app/helpers/application_helper.rb@, maybe it's better to cast both values @to_s@.
--------------------------------------------------------------------------------
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/116202079
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------
related_issues
relates,Closed,3848,Permission to log time for another user