Vote #80679: Editing a time entry for a locked user changes the user to the current user - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80679

完了

Editing a time entry for a locked user changes the user to the current user

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Time tracking_13

対象バージョン:

4.1.1_160

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/32973

category_id:

version_id:

160

issue_org_id:

32973

author_id:

107353

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

127

ステータス-->[Closed]

引用

説明

Steps to reproduce:

Add a time entry for another user (B)
Lock that user (B)
Edit the time entry
Observe that field User is selected with "me". !{border: 1px solid grey; width: 20%}.me.png!

Saving the time entry, it will lose the user.

journals

--------------------------------------------------------------------------------
I see two options to fix this:

1. We don't allow changing the user when the time entry is logged on a locked user.
2. We add the locked user to the list of users.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I see two options to fix this:
>
> 1. We don't allow changing the user when the time entry is logged on a locked user.
> 2. We add the locked user to the list of users.

I think the second option is better because the limitation suggested in option 1 may confuse users. In my opinion, there is no reason to disallow changing the user when the user of the time entry is locked.
--------------------------------------------------------------------------------
Here is the fix for the second option, but I would like a double check on the solution. The second patch renames and reorders the test added in #32959.

All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/116292306
--------------------------------------------------------------------------------
Committed and merged, thanks!
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,Closed,3848,Permission to log time for another user
relates,Closed,33341,Time entry user is shown twice in the User drop-down when editing spent time