プロジェクト

全般

プロフィール

Vote #80799

完了

Add missing test: ProjectCustomField creation

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
低め
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
152
issue_org_id:
33268
author_id:
88801
assigned_to_id:
332
comments:
6
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Hello

I would like to complete the test suite, and add a test about the creation of ProjectCustomFields.

Currently, the functional tests only relate to IssueCustomFields.

Thank you


diff --git a/test/functional/custom_fields_controller_test.rb b/test/functional/custom_fields_controller_test.rb
index 7f41888ff..8b5e33155 100644
--- a/test/functional/custom_fields_controller_test.rb
+++ b/test/functional/custom_fields_controller_test.rb
@@ -303,6 +303,29 @@ class CustomFieldsControllerTest < Redmine::ControllerTest
     assert_equal 1, field.trackers.size
   end

+  def test_create_project_custom_field
+    field = new_record(ProjectCustomField) do
+      post :create, :params => {
+          :type => "ProjectCustomField",
+          :custom_field => {
+            :field_format => "string",
+            :name => "test_new_project_custom_field",
+            :description => "",
+            :min_length => "",
+            :max_length => "",
+            :regexp => "",
+            :text_formatting => "",
+            :default_value => "",
+            :url_pattern => "",
+            :is_filter => "0",
+            :is_required =>"0"
+          }
+        }
+    end
+    assert_redirected_to "/custom_fields/#{field.id}/edit"
+    assert_equal "test_new_project_custom_field", field.name
+  end
+
   def test_create_with_project_ids
     assert_difference 'CustomField.count' do
       post :create, :params => {

journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Go Maeda, looks good to me, we can add this test to all stable versions or only to 4.2.0.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Go Maeda, looks good to me, we can add this test to all stable versions or only to 4.2.0.

Thank you for reviewing the patch.

Since the new test is not for detecting existing bugs, but simply adds a new test, I think it is appropriate to set the target version to 4.2.0.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.2.0_152 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0