Vote #80830: Clean-up workflows controller - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80830

完了

Clean-up workflows controller

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

5.0.0_155

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/33337

category_id:

version_id:

155

issue_org_id:

33337

author_id:

88801

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

Hello

Here is a patch which aims to refactor the WorkflowsController.
The patch does not change the behavior of the application, but use smaller methods and clearer code. The routes are also updated.

My goal was to use a specific action for each route, and do not use a same method for different purposes (so avoid checking if the request-method is "post" inside actions).

Hope this may help.

journals

--------------------------------------------------------------------------------
Thanks Vincent for the patch, I tried it yesterday and it looks great from my point of view.

I'm attaching a rebased version of the initial patch and a second patch that fixes to route name (@workflows_permissions_path@ should be @permissions_workflows_path@). All the tests pass (https://gitlab.com/redmine-org/redmine/-/commit/4ef4ea5047323756a3241eea660e11a383ea7711) with both patches.

I'm going to review the tests in the following days.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Update the patches for current trunk, the tests still pass.

Setting target to version:"5.0.0", I think it's a nice refactoring.
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Thank you for updating and committing this patch.
--------------------------------------------------------------------------------