Vote #80842: Use more efficient "exists?" instead of "first" in tests when checking the existence of rows - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #80842

完了

Use more efficient "exists?" instead of "first" in tests when checking the existence of rows

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

4.2.0_152

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/33367

category_id:

version_id:

152

issue_org_id:

33367

author_id:

332

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

When you check if any row exists, using @exists?@ that does not return ActiveRecord objects is more efficient than using @first@.

The attached patch replaces @first@ with @exists?@.

journals

--------------------------------------------------------------------------------
Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
Committed the patch.
--------------------------------------------------------------------------------