Vote #80849
完了Update jQuery to 3.5.1
0%
説明
jQuery 2 is end of life and we should update the code to support latest jQuery 3.5.0 (at this time).
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Here are two patches that update jQuery to 3.5.1 and fix a problem caused by "this":https://jquery.com/upgrade-guide/3.0/#breaking-change-jquery-event-props-and-jquery-event-fixhooks-removed change.
Because the update can break some plugins, I propose the following plan for this update:
# Commit the current patches
# Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
# After this period, commit "jQuery Migrate":https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin
# In Redmine version:"5.0.0", remove jQuery Migrate and keep only the latest jQuery version.
--------------------------------------------------------------------------------
Thank you for working on updating JQuery.
Marius BALTEANU wrote:
> Because the update can break some plugins, I propose the following plan for this update:
> # Commit the current patches
> # Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
> # After this period, commit "jQuery Migrate":https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin
I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.
Do you think it is OK to commit the patches right now?
--------------------------------------------------------------------------------
I think it is better to commit this patch as soon as possible in order to detect problems early. Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
Committed the patches. Thank you.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Thank you for working on updating JQuery.
>
> Marius BALTEANU wrote:
> > Because the update can break some plugins, I propose the following plan for this update:
> > # Commit the current patches
> > # Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
> > # After this period, commit "jQuery Migrate":https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin
>
> I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.
>
> Do you think it is OK to commit the patches right now?
Sorry for my late reply, yes, it's ok to have the patches committed.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Because the update can break some plugins, I propose the following plan for this update:
> # Commit the current patches
> # Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
> # After this period, commit "jQuery Migrate":https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin
> # In Redmine version:"5.0.0", remove jQuery Migrate and keep only the latest jQuery version.
Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?
--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Because the update can break some plugins, I propose the following plan for this update:
> > # Commit the current patches
> > # Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
> > # After this period, commit "jQuery Migrate":https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin
> > # In Redmine version:"5.0.0", remove jQuery Migrate and keep only the latest jQuery version.
>
> Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?
Yes, let's do it.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Added jQuery Migrate in r20518.
--------------------------------------------------------------------------------
We should remove the security fix for jQuery < 3.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> We should remove the security fix for jQuery < 3.
Done in r20709.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,33384,jQuery: replace deprecated size() method with length
relates,Closed,33392,Fix invalid selector in function displayTabsButtons()
relates,Closed,33896,Incorrect position of the revision graph
relates,Closed,34337,Remove jQuery Migrate
relates,Closed,35729,Update jQuery to 3.6.0