Vote #81096: Store inline autocomplete data sources in a JS variable - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #81096

完了

Store inline autocomplete data sources in a JS variable

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

4.2.0_152

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/34122

category_id:

version_id:

152

issue_org_id:

34122

author_id:

107353

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

When I've implemented first the inline autocomplete feature (version:"4.1.0") I chose to store the autocomplete data source path in a data attribute (@data-issue-url@) of each textarea field that support this feature. The solution touched 9 views files (r18444).

Since then, new requests came to support inline autocomplete for other sources like macros or wiki pages (#33425, #33820) and if we keep the current solution, we need to touch again the same files and add two new attributes. On a long term, the solution doesn't seem very efficient.

My proposal is to change the current implement and store all the paths in a JS variable, attached an working version.

Any feedback on this is really appreciated.

journals

+1
The change makes views clearner.
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------