プロジェクト

全般

プロフィール

Vote #81114

完了

MessagesControllerTest#test_post_new randomly fails

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
152
issue_org_id:
34169
author_id:
259873
assigned_to_id:
332
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

MessagesControllerTest # test_post_new test fails (trunk)

Failure:
MessagesControllerTest#test_post_new [/root/project/test/functional/messages_controller_test.rb:150]:
Expected: ["jsmith@somenet.foo"]
  Actual: ["dlopper@somenet.foo"]

bin/rails test test/functional/messages_controller_test.rb:121

There is no guarantee that the elements will be in the order of "first: author, second: member" in the array mails, so the test should be modified so that it does not depend on the order.


journals

Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
LGTM and thanks for fixing. This test was very flaky on PostgreSQL and caused many false positive failures.

This fix will make development much easier.
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン4.2.0_152 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0