Vote #81205
完了Rename the save, edit and delete buttons on the query form to clarify the scope
0%
説明
It's hard to tell that the subject of the Save, Edit and Delete buttons on the Query form is a custom query.
How about changing it as follows?
- Save => Save custom query
- Edit => Edit custom query
- Delete => Delete custom query
!{width: 70%; border: 1px solid #ccc}save_after_change.png!
!{width: 70%; border: 1px solid #ccc}edit_and_delete_after_change.png!
journals
I like this proposal for two reasons even though it comes at the cost of adding three new i18n-strings:
# it makes it clearer that these three buttons operate at the custom -field- +query+ scope;
# plugins can generically re-use these i18n-strings for their own objects.
_Edited by Mischa The Evil, 2021-08-14 04:38._
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
I’m not sure that renaming these 3 buttons is the best solution. Apply & Clear operates at the same level, why are not renamed to Apply custom query and Clear custom query?
From my point of view, a better solution is a UI one which clearly defines the button as part of the custom query section.
Any other feedback in welcome on this topic.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I’m not sure that renaming these 3 buttons is the best solution. Apply & Clear operates at the same level, why are not renamed to Apply custom query and Clear custom query?
Clear and Apply are generic terms for search, and I thought it would be easy to understand without adding a subject.
On the other hand, Save, Edit and Delete are hard to understand without the subject.
As far as I know, many people were unaware that custom queries could be saved and reused.
I think it's better to explain in text so that those people can understand the function.
> From my point of view, a better solution is a UI one which clearly defines the button as part of the custom query section.
I think it is more effective to have a better UI and -linguistic explanation- explanation text at the same time.
--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
>
> I think it is more effective to have a better UI and linguistic explanation at the same time.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Mizuki ISHIKAWA wrote:
> >
> > I think it is more effective to have a better UI and linguistic explanation at the same time.
It's a valid point.
--------------------------------------------------------------------------------
We need more feedback on this.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> [...] Apply & Clear operates at the same level [...]
I think it depends on your perspective. I'll elaborate.
From a front-end end-user perspective I do not agree. Apply and Clear operate on the _issue list_ whereas Save, Edit and Delete operate on a _custom query_. Compare:
* Clicking Apply takes all the set filters and options and _generates a new (in-memory) issue list_.
* Clicking Clear resets all the filters and options and _generates a new (in-memory) issue list_.
* Clicking Save takes all the set filters and options and generates a pre-set form that lets me save _my custom query to the DB_.
* Clicking Edit generates a pre-set form that lets me edit and save _my custom query to the DB_.
* Clicking Delete generates a confirmation pop-up with the ability that lets me delete _my custom query from the DB_.
From a back-end perspective I do agree with you more. From that perspective all these actions effectively operate on an @IssueQuery@. But even here there's a difference: that's persistence. Apply and Clear do not operate on a persistent object (custom query in the DB), while Save, Edit and Delete do.
Marius BALTEANU wrote:
> [...] why are not renamed to Apply custom query and Clear custom query?
Based on the rationale outlined above: because these actions do not operate on a custom query object that is saved in the DB, they operate effectively only on the issue list.
--------------------------------------------------------------------------------
Thanks Mischa for your detailed feedback! I'm not against this change, we can do it.
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.
--------------------------------------------------------------------------------
related_issues
relates,Closed,31278,Change Delete button name to Delete issue