When I added the "Copy link" icon, it was crowded with many icons displayed on the view.
So this patch hides infrequently used action links in actions-dropdown, just like wiki pages.

!screenshot_2021-02-10_16.15.22.png!
!screenshot_2021-02-10_16.14.35.png!

If it is better to separate the patch that adds the function to copy the URL and the patch that combines the Action icons, it will be supported.
This patch contains an icon image, so apply it with the git apply command.
--------------------------------------------------------------------------------
For your reference, I've attached a patch with a pattern that doesn't combine the "Copy link" icon into actions-dropdown. (I don't like this UI very much)
--------------------------------------------------------------------------------
I really like the ideea of moving the Delete icons under the actions dropdown, I think we should extract it from your patch and added a separat tichet. From my point of view, this solution is a good fix for #31278.

Also, having the copy link it's a nice and useful feature.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I really like the ideea of moving the Delete icons under the actions dropdown, I think we should extract it from your patch and added a separat tichet. From my point of view, this solution is a good fix for #31278.

Good point there.

> Also, having the copy link it's a nice and useful feature.

I like the feature, too. Sharing a link in a chat is a bit tedious at the moment.

I've tried your patch and it worked quite well. The only thing I've missed was some kind of feedback after copying the URL to the clipboard. On all web applications which allowed me to copy stuff to the clipboard I got a toast or little message, that the job has finished. So I felt a bit awkward after clicking the copy link without anything happening.
--------------------------------------------------------------------------------
Thank you for your feedback.

Marius BALTEANU wrote:
> I really like the ideea of moving the Delete icons under the actions dropdown, I think we should extract it from your patch and added a separat tichet. From my point of view, this solution is a good fix for #31278.

I split the patch and attached it to the #34714 issue.

Bernhard Rohloff wrote:
> I've tried your patch and it worked quite well. The only thing I've missed was some kind of feedback after copying the URL to the clipboard. On all web applications which allowed me to copy stuff to the clipboard I got a toast or little message, that the job has finished. So I felt a bit awkward after clicking the copy link without anything happening.

I think if I put the "Copy link" link inside the Actions dropdown, pressing the copy button will close the Dropdown as feedback that the work is done.
GitHub and Gitlab also put a "Copy link" in the dropdown and do not show the message that the work is completed.
However, if you accidentally click outside the dropdown, the dropdown will close, which may be incomplete feedback in that you don't know if the copy is really complete.

In the patch for #34703#note-2, I have implemented a mechanism to display a message after the copy is completed, so I will try if I can incorporate that into the patch for #34703#note-1.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Since #34714 was committed, I modified feature-34703-1.patch accordingly.
I also added a System test.
--------------------------------------------------------------------------------
Bernhard Rohloff wrote:
> The only thing I've missed was some kind of feedback after copying the URL to the clipboard. On all web applications which allowed me to copy stuff to the clipboard I got a toast or little message, that the job has finished. So I felt a bit awkward after clicking the copy link without anything happening.

I agree that it would be even better to have feedback when the link is copied.

But how about committing the current patch first, and improving the feedback display in the future? I think the feature is useful even without feedback. And as Mizuki already wrote, the equivalent feature of GitHub and Gitlab also don't show feedback when a link is copied.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> But how about committing the current patch first, and improving the feedback display in the future? I think the feature is useful even without feedback. And as Mizuki already wrote, the equivalent feature of GitHub and Gitlab also don't show feedback when a link is copied.

Of course! It's a useful feature and we should add it to Redmine. A bit of feedback would just be the icing on the cake. :-)

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I changed the icon to an image created by combining a copy icon and a link icon.

!screenshot-2021-03-16-11.20.14.png!
--------------------------------------------------------------------------------
Bernhard Rohloff wrote:
> Go MAEDA wrote:
> > But how about committing the current patch first, and improving the feedback display in the future? I think the feature is useful even without feedback. And as Mizuki already wrote, the equivalent feature of GitHub and Gitlab also don't show feedback when a link is copied.
>
> Of course! It's a useful feature and we should add it to Redmine. A bit of feedback would just be the icing on the cake. :-)

I've also written a patch that adds feedback, but I'm a little confused about how to implement it, so I'm thinking of making another issue after this feature is committed.
--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
> I changed the icon to an image created by combining a copy icon and a link icon.

I accidentally attached an old patch.

--------------------------------------------------------------------------------
Setting the target version to 4.2.0.
--------------------------------------------------------------------------------
@test/system/copy_to_clipboard_test.rb@ fails on macOS. Could you fix the test to support macOS? Probably source:trunk/test/system/keyboard_shortcuts_test.rb@20729#L125 is helpful.

<pre>
[Screenshot]: tmp/screenshots/failures_test_copy_issue_url_to_clipboard.png
F

Failure:
CopyToClipboardSystemTest#test_copy_issue_url_to_clipboard [test/system/copy_to_clipboard_test.rb:40]:
Expected false to be truthy.

bin/rails test test/system/copy_to_clipboard_test.rb:29

[Screenshot]: tmp/screenshots/failures_test_copy_issue_journal_url_to_clipboard.png
F

Failure:
CopyToClipboardSystemTest#test_copy_issue_journal_url_to_clipboard [test/system/copy_to_clipboard_test.rb:54]:
Expected false to be truthy.

bin/rails test test/system/copy_to_clipboard_test.rb:43
</pre>
--------------------------------------------------------------------------------
Go MAEDA wrote:
> @test/system/copy_to_clipboard_test.rb@ fails on macOS. Could you fix the test to support macOS? Probably source:trunk/test/system/keyboard_shortcuts_test.rb@20729#L125 is helpful.
>
> [...]

I think it will be fixed by applying this patch in addition to the 0001 patch.
--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.

Users can copy a URL of an issue or an issue journal by clicking "Copy link" in the action menu.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

relates,Closed,34714,Move delete button for issues and journals to the dropdown menu
relates,Closed,34932,"Copy link" feature for issues list