Vote #81261
完了Hooks for queries helper
0%
説明
Plugin developers very often overwrite queries helper column_value and column_content.
The problem is, that there two ways to overwrite it: prepend and alias_method. There is a conflict if one plugin uses prepend and the other plugin uses alias_method for the same method.
More and more plugins do not work together because of this reason. Because of this, there should be a better way to solve this wish to overwrite.
I added a patch to introduce two hooks, which could be used by plugin develops. With this approach there is no need for overwriting this method anymore.
journals
Alexander Meindl wrote:
> Plugin developers very often overwrite queries helper _column_value_ and _column_content_.
Could you show me some plugins that do that?
--------------------------------------------------------------------------------
Hi Go MAEDA,
thanks for responding.
Here is a list of some plugins which overwrites query helper methods:
* "redmine_multiprojects_issue":https://github.com/nanego/redmine_multiprojects_issue
* "redmine_checklists":https://www.redmine.org/plugins/redmine_checklists
* "additional_tags":https://www.redmine.org/plugins/additional_tags (with conflict "issue":https://github.com/AlphaNodes/additional_tags/issues/9 for more information)
* "redmine_contacts_helpdesk":https://www.redmine.org/plugins/redmine_contacts_helpdesk
* "redmineup_tags":https://www.redmine.org/plugins/redmineup_tags
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Hi Go MAEDA
Can anything be done to bring forward the integration of this patch? This has the potential to solve a fairly sizable problem hampering plugin developers, and users of those plugins alike.
Quickly perusing what is listed in version:"Candidate for next major release" and it seems like many enhancements simply go there to die, numerous patches are 5+ years old. Please do reconsider whether this solution can be safely implemented within the next minor release.
--------------------------------------------------------------------------------
Adjusted indentation to conform with the current coding style of Redmine.
Setting the target version to 5.0.0.
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------