Vote #81311
完了User link using @ not working at the end of line
0%
説明
Redmine fails to parse mention like @jsmith. (with dot at the end)
At source:trunk/app/helpers/application_helper.rb#L1286 regex extracts full line with all extra sybmols like _-@. and thus can't fide a user with that login.
It only affects separator @, user:jsmith. or user#2. works fine.
Small patch with fix and test in attachment.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Dmitry, thanks for reporting and fixing this issue, it looks good to me with one mention: we don't need a new test for this case, it's enough to add this case at the existing test.
The patch passes all the tests: https://gitlab.com/redmine-org/redmine/-/pipelines/284519558
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> we don't need a new test for this case, it's enough to add this case at the existing test.
Just wanted to show the difference between other regexs in same situation. Initially only @ was a problem.
--------------------------------------------------------------------------------
Committed the fix. Thank you all for reporting and fixing the issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------