プロジェクト

全般

プロフィール

Vote #81389

完了

Update config/environments/*.rb for Rails 6.1

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Rails support_44
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
44
version_id:
155
issue_org_id:
35081
author_id:
332
assigned_to_id:
332
comments:
6
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

The attached patch updates Rails environment files (development.rb, production.rb, and test.rb in config/environments directory) for Rails 6.1.

By updating the files, several useful new features in Rails 6.1 will be available (e.g. request_id in production.log, verbose_query_logs in development.log). Also, by looking at the commented out settings, the user can easily know what settings are available (e.g. config.force_ssl in config/environments/production.rb).


journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
The patch adds two settings in @config/environments/production.rb@ which are already defined in @config/application.rb@ with the same value:
* @config.log_level = :info@ already defined in source:/trunk/config/application.rb#L77
* @config.i18n.fallbacks = true@ already defined in source:/trunk/config/application.rb#L57

Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling @config.assets.css_compressor = :sass@ it will break Redmine (at least in my local environment).
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> The patch adds two settings in @config/environments/production.rb@ which are already defined in @config/application.rb@ with the same value:
> * @config.log_level = :info@ already defined in source:/trunk/config/application.rb#L77
> * @config.i18n.fallbacks = true@ already defined in source:/trunk/config/application.rb#L57

Fixed.

> Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling @config.assets.css_compressor = :sass@ it will break Redmine (at least in my local environment).

I checked through configs in the files and removed @config.assets.*@ in @config/environments/development.rb@ and @config/environments/production.rb@.

Thank you for reviewing the patch.
--------------------------------------------------------------------------------
Setting the target version to 5.0.0.
--------------------------------------------------------------------------------
Committed the patches.
--------------------------------------------------------------------------------


related_issues

relates,Closed,29914,Migrate to Rails 6.1 with Zeitwerk autoloading

Admin Redmine さんが3年以上前に更新

  • カテゴリRails support_44 にセット
  • 対象バージョン5.0.0_155 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0