Vote #81421
未完了Watchers pop up window appears after a long time
0%
説明
Hi
patch #33329 introduces a performance issue
When you want to add a watcher to an issue in a project with many collaborators, the pop-up window take between 10 sec and 20 sec (according to the number of collaborators) to appear.
It's very disturbing because user has no graphical indication about that.
regards
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
How many members do you have on the project where you experience this issue? (rounded number).
In #33329, I've proposed two options (4 and 5) to avoid this performance issue, which one works better for you?
--------------------------------------------------------------------------------
Hi
when it took 10 seconds to pop up, there is 900 members.
when it took 25 seconds, there is 2500 members.
it's linear
I prefer the option 4
--------------------------------------------------------------------------------
Hello Marius,
Thank you for the patch #33329 that is good improvement for sure.
But we do have the same perfomance problem with 1300+ users.
<pre>watchable_object.visible?(user)</pre> is making at least two SQL queries per user.
I don't think we need all users names listed when the search query is *blank*. so I would like to request *option 4*.
As a test, I made this change and it reduced loading time from 4 sec to 0.2 sec.
<pre><code class="diff">
- scope = @project.principals.assignable_watchers
+ scope = @project.principals.assignable_watchers.limit(100)
</code></pre>
--------------------------------------------------------------------------------
related_issues
relates,Closed,33329,Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the object