Vote #81477
未完了Improve project deletion warning text
0%
説明
This is related to #34417
The information text when deleting the user clearly states that deleting the user cannot be undone and that locking the user would be an alternative. This patch adds similar text stating the finality of deleting a project and the alternative of archiving the project to the project deletion information text.
journals
--------------------------------------------------------------------------------
The attached patch adds an "archive" link to the project deletion form. The guard for if the user is an admin is necessary because only admins can archive a project but non-admin users might be able to delete projects.
We can furthermore offer CSS to make the archive link resemble a button and to add an alert colour to the "delete" button of the project and user destroy pages. Please let me know if we should work on and provide such CSS.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
attachment:35373-1.patch does not render the "Archive" link as a button but as a text link.
How about using @submit_tag@ instead of @link_to@ in order to render the "Archive" as a button and for the consistency with @app/views/users/destroy.html.erb@?
<pre><code class="diff">
diff --git a/app/views/projects/destroy.html.erb b/app/views/projects/destroy.html.erb
index f2c97449b..043cb1c5c 100644
--- a/app/views/projects/destroy.html.erb
+++ b/app/views/projects/destroy.html.erb
@@ -26,6 +26,9 @@
<p>
<%= submit_tag l(:button_delete) %>
+ <% if User.current.admin? and !@project_to_destroy.archived? %>
+ <%= submit_tag l(:button_archive), name: 'archive' %>
+ <% end %>
<%= link_to l(:button_cancel), User.current.admin? ? admin_projects_path : projects_path %>
</p>
<% end %>
</code></pre>
--------------------------------------------------------------------------------
Go MAEDA wrote:
> attachment:35373-1.patch does not render the "Archive" link as a button but as a text link.
>
> How about using @submit_tag@ instead of @link_to@ in order to render the "Archive" as a button and for the consistency with @app/views/users/destroy.html.erb@?
This is a good idea but would require patching the @ProjectsController@ too, as @ProjectsController#destroy@ does not understand archiving a project. Or we could wrap another form around the archive button.
Should we look into adapting the patch this way?
--------------------------------------------------------------------------------
related_issues
relates,Closed,34417,Require explicit confirmation when deleting a user or a project
Admin Redmine さんがほぼ4年前に更新
- カテゴリ を UI_10 にセット
- 対象バージョン を Candidate for next major release_32 にセット