Vote #81482: Use base_scope for issue query results - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #81482

完了

Use base_scope for issue query results

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

5.0.0_155

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/35396

category_id:

version_id:

155

issue_org_id:

35396

author_id:

29628

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

This is some refactoring, which drops redundant definition of query scope. With this change, base_scope is used for issues.

Second advantage is, plugin developer can overwrite base_scope to include more features (e.g. for search filter).

There are no downsides with it.

journals

I created a second patch, which also uses base_scope for issue_ids.
--------------------------------------------------------------------------------
IssueQuery#base_scope was added in r14642. I think the proposed changes should have been included in r14642.
--------------------------------------------------------------------------------
Setting the target version to 5.0.0.
--------------------------------------------------------------------------------
Committed the patch. Thank you.
--------------------------------------------------------------------------------