I tried to see the result here :

!https://www.gravatar.com/avatar/4a042b8382a008d344561c8301509f3a?s=32&d=identicon&r=PG!

On redmine 4.2.1, the image don't appear, I see all the textile code in place.

<pre>
!https://www.gravatar.com/avatar/4a042b8382a008d344561c8301509f3a?s=32&d=identicon&r=PG!
</pre>
--------------------------------------------------------------------------------
Test on new installation of REDMINE 4.2.1 on Windows with Ruby 2.7.3

--------------------------------------------------------------------------------
Thank you for reporting the issue. I have confirmed the issue on the latest trunk.

But the latest 4.2-stable branch (including released 4.2.1) is not affected. Maybe you are using the trunk or the master branch of GitHub, aren't you? Their version number is also "4.2.1" but has ".devel" suffix (e.g. "4.2.1.devel").
--------------------------------------------------------------------------------
I used github 4.2-stable branch for my install

Environment:
Redmine version 4.2.1.stable
Ruby version 2.7.3-p183 (2021-04-05) [x64-mingw32]
Rails version 5.2.6
Environment production
Database adapter PostgreSQL
Mailer queue ActiveJob::QueueAdapters::AsyncAdapter
Mailer delivery smtp
SCM:
Subversion 1.8.16
Git 2.29.2
Filesystem
Redmine plugins:
no plugin installed
--------------------------------------------------------------------------------
In the case of Textile, @RedCloth3#inline_textile_image@(source:/trunk/lib/redmine/wiki_formatting/textile/redcloth3.rb#L950) is executed to generate the image tag, but the image could not be displayed because False is returned in @Redmine::Helpers::URL#uri_with_safe_scheme?@(source:/trunk/lib/redmine/helpers/url.rb#L25).
In @uri_with_safe_scheme?@, the string converted of the input URI (including query string) by @RedCloth3#incomming_entries@(source:/trunk/lib/redmine/wiki_formatting/textile/redcloth3.rb#L1001) is passed as a parameter. However, an error occurred because this conversion string could not be parsed by @URI.parse@ of source:/trunk/lib/redmine/helpers/url.rb#L31 .
The following patch removes the query string from the conversion string.

<pre><code class="diff">
diff --git a/lib/redmine/helpers/url.rb b/lib/redmine/helpers/url.rb
index 0c6cbdecd7..40801ee7c8 100644
--- a/lib/redmine/helpers/url.rb
+++ b/lib/redmine/helpers/url.rb
@@ -28,7 +28,7 @@ module Redmine
return true unless uri.to_s.include? ":"

# Other URLs need to be parsed
- schemes.include? URI.parse(uri).scheme
+ schemes.include? URI.parse(uri.split('?').first).scheme
rescue URI::Error
false
end
</code></pre>
--------------------------------------------------------------------------------
I found that the issue is reproducible when the version of Ruby is 2.7 or higher. This is because @URI.parse@ in Ruby 2.7 or later raises @URI::InvalidURIError@ if the query string in a given URI is invalid.

As explained in #35441#note-5, the Textile formatter temporarily replaces "&" in URIs with two "x%" (source:tags/4.2.1/lib/redmine/wiki_formatting/textile/redcloth3.rb#L1001). The conversion makes a URI with a query string malformed. The malformed URI causes @URI::InvalidURIError@ while checking if the URI scheme is safe at source:tags/4.2.1/lib/redmine/helpers/url.rb#L31.

It has never caused the reported problem before because @URI.parse@ in Ruby 2.6 or earlier allows URIs with such a malformed query string.
--------------------------------------------------------------------------------
Update the patch.

* Add a test that describes the issue to @ApplicationHelperTest#test_inline_images@
* Remove a query string in @RedCloth3#inline_textile_image@ instead of @Redmine::Helpers::URL.uri_with_safe_scheme?@. This is because the cause of the issue is the temporary data conversion of @RedCloth3#inline_textile_image@ and Markdown formatter is not affected by the issue at all
* Replaced @String#split@ with faster @String#partition@
--------------------------------------------------------------------------------
Setting the target version to 4.2.2.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I did some research on the background of this change in Ruby to see what changed exactly and why, and if it was an intentional change or a regression bug.

To summarize:
* It was an intentional change introduced in Ruby 2.7.x.
** "Upstream Ruby issue":https://bugs.ruby-lang.org/issues/11275
** "Upstream GitHub commit":https://github.com/ruby/ruby/commit/7909f06212ae8df6ba7203f8152292a190b2b33a
* It was a change to fix a regression introduced in Ruby 2.2.x (so this would not have been an issue when Redmine was running on Ruby <= 2.1.x)
** "Upstream GitHub commit":https://github.com/ruby/ruby/commit/21ab98a997d2ed44c9c95cf5434a42561b2cd688#diff-34d4a062b271fc0687096554d66183d8L5

--------------------------------------------------------------------------------
Committed the patch. Thank you for your contribution.

Mischa The Evil wrote:
> I did some research on the background of this change in Ruby to see what changed exactly and why, and if it was an intentional change or a regression bug.
>
> To summarize:
> * It was an intentional change introduced in Ruby 2.7.x.
> ** "Upstream Ruby issue":https://bugs.ruby-lang.org/issues/11275
> ** "Upstream GitHub commit":https://github.com/ruby/ruby/commit/7909f06212ae8df6ba7203f8152292a190b2b33a
> * It was a change to fix a regression introduced in Ruby 2.2.x (so this would not have been an issue when Redmine was running on Ruby <= 2.1.x)
> ** "Upstream GitHub commit":https://github.com/ruby/ruby/commit/21ab98a997d2ed44c9c95cf5434a42561b2cd688#diff-34d4a062b271fc0687096554d66183d8L5

Thank you for your detailed investigation.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

relates,Closed,31500,Ruby 2.7 support
relates,New,29681,"x%x%" is rendered as "&" in Textile formatter