Vote #81542
完了Cleanups after Wiki tab removal from project settings (#26579)
0%
説明
This is extracted from #34643.
- 1. Remove '@edit@' action from @:manage_wiki permission@ definition in @Redmine::AccessControl@. @Wikis#edit@ is removed by r17018.
- 2. Redirect_to @project_path@ after @WikisController#destroy@. ** Project settings 'wiki' tab is removed by r16917 & r17017. ** This action is executed outside the project settings scope after r16916, thus we can better redirect to @project_path@.
- 3. Set @:wiki@ @menu_item@ for @WikisController#destroy@. This action is executed inside the project wiki scope after r16916, thus we can better set the @menu_item@ accordingly.
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Patches committed, thank you.
--------------------------------------------------------------------------------
Thanks for handling this. Now that I've had a second look at this though, I noticed that the remaining 'edit' JavaScript view (source:/trunk/app/views/wikis/edit.js.erb) is obsolete too and that it can be removed. Can this be handled via this issue (without a patch from me) too?
--------------------------------------------------------------------------------
Mischa The Evil wrote:
> Thanks for handling this. Now that I've had a second look at this though, I noticed that the remaining 'edit' JavaScript view (source:/trunk/app/views/wikis/edit.js.erb) is obsolete too and that it can be removed. Can this be handled via this issue (without a patch from me) too?
View removed in r21105, thanks.
--------------------------------------------------------------------------------
related_issues
copied_to,Closed,34643,Cleanups and fixes after Wiki tab removal from project settings (#26579)
Admin Redmine さんが4年以上前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 5.0.0_155 にセット