Vote #81746: Add missing fixture to IssuesHelperTest - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #81746

完了

Add missing fixture to IssuesHelperTest

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

5.0.0_155

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/36347

category_id:

version_id:

155

issue_org_id:

36347

author_id:

362529

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

IssuesHelperTest has failed. If you run the commands (rake db:migrate:reset, the test with seed value) in the following order, the test will always fail.

% RAILS_ENV=test bundle exec rake db:migrate:reset

% RAILS_ENV=test bundle exec rake test TESTOPTS="--seed 57576"
(Test LDAP server not configured)
Bazaar non ASCII output test cannot run on this environment.
Encoding.locale_charmap: UTF-8
Skipping LDAP tests.
Run options: --seed 57576

# Running:

.....F

Failure:
IssuesHelperTest#test_render_relations_stats [test/helpers/issues_helper_test.rb:435]:
"1 open" not found in "2 (2 open — 0 closed)" 

rails test test/helpers/issues_helper_test.rb:421

...............F

Failure:
IssuesHelperTest#test_render_descendants_stats [test/helpers/issues_helper_test.rb:417]:
"1 open" not found in "2 (2 open — 0 closed)" 

rails test test/helpers/issues_helper_test.rb:409

..........

journals

The cause was an insufficient fixture. The following patch will solve the issue.

<pre><code class="diff">
diff --git a/test/helpers/issues_helper_test.rb b/test/helpers/issues_helper_test.rb
index 0b3325ad77..974e30ac62 100644
--- a/test/helpers/issues_helper_test.rb
+++ b/test/helpers/issues_helper_test.rb
@@ -34,7 +34,7 @@ class IssuesHelperTest < Redmine::HelperTest
:enabled_modules,
:custom_fields,
:attachments,
- :versions
+ :versions, :workflows

def test_issue_heading
assert_equal "Bug #1", issue_heading(Issue.find(1))
</code></pre>
--------------------------------------------------------------------------------
Confirmed the issue. Setting the target version to 5.0.0.

<pre>
$ RAILS_ENV=test bin/rake db:reset
Dropped database 'db/test.sqlite3'
Created database 'db/test.sqlite3'
$ bin/rails test test/helpers/issues_helper_test.rb:421
Run options: --seed 9426

# Running:

Failure:
IssuesHelperTest#test_render_relations_stats [/Users/maeda/redmines/redmine-trunk/test/helpers/issues_helper_test.rb:435]:
"<a href="/issues?issue_id=16%2C17&set_filter=true&status_id=o">1 open</a>" not found in "<a href="/issues?issue_id=16%2C17&set_filter=true&status_id=%2A">2</a> (<a href="/issues?issue_id=16%2C17&set_filter=true&status_id=o">2 open</a> — 0 closed)"

rails test test/helpers/issues_helper_test.rb:421

Finished in 2.816515s, 0.3550 runs/s, 0.7101 assertions/s.
1 runs, 2 assertions, 1 failures, 0 errors, 0 skips
</pre>
--------------------------------------------------------------------------------
Committed the fix. Thank you.
--------------------------------------------------------------------------------