Vote #81774
完了Avoid passing ActionController::Parameters outside of MailHandlerController
0%
説明
Currently the @MailHandlerController@ passes an instance of @ActionController::Parameters@ to the @MailHandler@. The @options@ holds a duplicate @ActionController::Parameters@ of the Controller @params@.
This can cause difficulties in later processing. We propose explicitly @permit@-ing the @params@ that will be used later and using a Hash for the @options@.
journals
I have forgotten to add a link to the source code source:/trunk/app/controllers/mail_handler_controller.rb@21350#L31
--------------------------------------------------------------------------------
The attached patch allows all options set by @rdm-mailhandler.rb@ source:/trunk/extra/mail_handler/rdm-mailhandler.rb@21350#L156. This will need to be kept in sync, so maybe adding a comment on both sides will make it easier to remember to add new options to the other side too.
--------------------------------------------------------------------------------
Felix Schäfer wrote:
> The attached patch allows all options set by @rdm-mailhandler.rb@ source:/trunk/extra/mail_handler/rdm-mailhandler.rb@21350#L156. This will need to be kept in sync, so maybe adding a comment on both sides will make it easier to remember to add new options to the other side too.
Updated the patch to add a comment on app/controllers/mail_handler_controller.rb and extra/mail_handler/rdm-mailhandler.rb.
--------------------------------------------------------------------------------
Setting the target version to 5.0.0.
--------------------------------------------------------------------------------
Patch committed, thanks!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Admin Redmine さんが4年以上前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 5.0.0_155 にセット